refactor: Enable SELECT * optimization when compiling read-table nodes into sqlglot#2430
Open
chelsea-lin wants to merge 3 commits intomainfrom
Open
refactor: Enable SELECT * optimization when compiling read-table nodes into sqlglot#2430chelsea-lin wants to merge 3 commits intomainfrom
SELECT * optimization when compiling read-table nodes into sqlglot#2430chelsea-lin wants to merge 3 commits intomainfrom
Conversation
product-auto-label
bot
added
size: m
chelsea-lin
force-pushed
the
main_chelsealin_selectstart
branch
from
e085050 to
f5a2276
Compare
TrevorBergeron
requested changes
Feb 4, 2026
Comment on lines
+59
to
+62
| nodes.ScanItem( | ||
| identifiers.ColumnId(scan_item.source_id), scan_item.source_id | ||
| ) | ||
| for scan_item in node.scan_list.items |
Contributor
There was a problem hiding this comment.
I think what we really want is to order by the underlying physical schema?
| @property | ||
| def is_star_selection(self) -> bool: | ||
| physical_names = tuple(item.name for item in self.source.table.physical_schema) | ||
| scan_names = tuple(item.source_id for item in self.scan_list.items) |
Contributor
There was a problem hiding this comment.
the scan list item id must equal source_id as well for this to work as intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 481740136 🦕